-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reMarkable 1 support #14
base: main
Are you sure you want to change the base?
Conversation
Fixes #13 |
@funkey is there anything you'd like me to change before merging? |
Hi Nathaniel, Thanks a lot for the PR. Adding RM1 support is great, happy to include that. However, I don't want to remove the precompiled binaries. The reason I include them along the source is that not every user of So I suggest you either keep the precompiled binaries (they are tiny) or add a script to download them as you suggested. I'd very much prefer the former. |
Let me clarify, I wasn't suggesting a script to download them, I was suggesting adding an artifact to a release tag that users can download that contains the existing I wouldn't mind taking some time to automate this with github actions if you'd like. |
I see. Sure, go ahead then, sounds good to me! |
Sorry for how long this took. I had some stuff come up. I've only automated the build here, but you should be able to automate creating a new version on merge to master, and attaching the build artifacts. |
Example run since you have to allow my pull request to run this: https://github.com/Eeems/recept/actions/runs/4887019353 |
@funkey poke? |
@funkey poke again? |
I removed the precompiled binaries since it's not really best practice to include them in the source. Instead I'd recommend uploading a zip containing them and
install.sh
to a release tag.