Modernize addon

[charlesfries]

WIP

[seanCodes]

@charlesfries Yes, thanks for this! Hope it gets merged.

[fsmanuel]

@charlesfries ❤️ will take a look as soon as I find some time.

[fsmanuel]

That already looks like a pretty good job! Thank you so much!
I spotted 2 things and will take another look when you are done.

[fsmanuel]

Do we need this? I think the addon has nothing to render...

[charlesfries]

@fsmanuel you are correct, however removing ember-cli-htmlbars causes a Missing template processor error. Possibly just need to remove some older broccoli packages

Stacktrace

ERROR Summary:

- broccoliBuilderErrorStack: [undefined]
- code: [undefined]
- codeFrame: [undefined]
- errorMessage: Missing template processor
- errorType: [undefined]
- location:
  - column: [undefined]
  - file: [undefined]
  - line: [undefined]
- message: Missing template processor
- name: Error
- nodeAnnotation: [undefined]
- nodeName: [undefined]
- originalErrorMessage: [undefined]
- stack: Error: Missing template processor
  at module.exports.preprocessTemplates (C:\Users\cfries\Documents\Repositories\ember-local-storage\node_modules\ember-cli-preprocess-registry\preprocessors.js:166:11)
  at DefaultPackager.processTemplates (C:\Users\cfries\Documents\Repositories\ember-local-storage\node_modules\ember-cli\lib\broccoli\default-packager.js:444:9)
  at DefaultPackager.processAppAndDependencies (C:\Users\cfries\Documents\Repositories\ember-local-storage\node_modules\ember-cli\lib\broccoli\default-packager.js:225:14)
  at DefaultPackager.packageJavascript (C:\Users\cfries\Documents\Repositories\ember-local-storage\node_modules\ember-cli\lib\broccoli\default-packager.js:1180:32)
  at EmberAddon._legacyPackage (C:\Users\cfries\Documents\Repositories\ember-local-storage\node_modules\ember-cli\lib\broccoli\ember-app.js:1638:48)
  at EmberAddon.toTree (C:\Users\cfries\Documents\Repositories\ember-local-storage\node_modules\ember-cli\lib\broccoli\ember-app.js:1684:27)
  at module.exports (C:\Users\cfries\Documents\Repositories\ember-local-storage\ember-cli-build.js:29:14)
  at Builder.readBuildFile (C:\Users\cfries\Documents\Repositories\ember-local-storage\node_modules\ember-cli\lib\models\builder.js:49:14)
  at Builder.setupBroccoliBuilder (C:\Users\cfries\Documents\Repositories\ember-local-storage\node_modules\ember-cli\lib\models\builder.js:63:22)
  at new Builder (C:\Users\cfries\Documents\Repositories\ember-local-storage\node_modules\ember-cli\lib\models\builder.js:29:10)

[fsmanuel]

Does it help to add ember-cli-htmlbars to the devDependencies?

[fsmanuel]

Let me know if I can be of any help!

[fsmanuel]

@charlesfries I enabled Github actions and needed to also update ember-cli to make it all work.
I love the work you did! Could you rebase your branch so we can iterate on all the goodies from this PR?

I disabled all the linting rules so we can enable them in your branch because I think you already fixed all the warnings.

[charlesfries]

Just merged the changes into my branch. FYI I ran into a TypeError: decorator is not a function error that I couldn't get past. that's where I last left it

[fsmanuel]

@charlesfries great. Can you run yarn and push the new yarn.lock so the tests can run.
I'll have a look at the new diff and try to reproduce the TypeError: decorator is not a function.