Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 디자인 2차 수정 #165

Open
wants to merge 10 commits into
base: feat/v2
Choose a base branch
from
1 change: 1 addition & 0 deletions src/components/Product/ProductItem/productItem.css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export const productImage = style({
width: '100%',
height: 'auto',
minWidth: 163,
borderRadius: '6px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
borderRadius: '6px',
borderRadius: 6,

..!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 저도 그렇게 이해함.!

objectFit: 'cover',
aspectRatio: '1 / 1',
});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Link } from 'react-router-dom';

import { container, moreItem, notFound, recipeLink } from './productRecipeList.css';
import { container, moreItem, notFound, recipeLink, wrapper } from './productRecipeList.css';

import SearchNotFoundImage from '@/assets/search-notfound.png';
import { Text, ShowAllButton } from '@/components/Common';
Expand Down Expand Up @@ -41,7 +41,7 @@ const ProductRecipeList = ({ productId, productName }: ProductRecipeListProps) =
return (
<ul className={container}>
{recipeToDisplay.map((recipe) => (
<li key={recipe.id}>
<li key={recipe.id} className={wrapper}>
<DefaultRecipeItem recipe={recipe} />
</li>
))}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ export const container = style({
overflowX: 'auto',
});

export const wrapper = style({
height: '100%',
display: 'flex',
flex: '0 0 160px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS 고수시네요?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프론트엔드 시니어와 함께 한 CSS랄까요~~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시니어 여전히 믿음직 하네요 👍

});

export const moreItem = style({
display: 'flex',
justifyContent: 'center',
Expand Down
4 changes: 2 additions & 2 deletions src/components/Recipe/CommentForm/commentForm.css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ export const container = style({
export const commentForm = style({
display: 'flex',
gap: 8,
alignItems: 'flex-end',
alignItems: 'center',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 근데 댓글이 길어지면 어떻게 보이나요? 저 이거 작업할 때 꽤나 골머리 앓았던 기억이 있어가지고

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크린샷 2024-07-27 오후 4 12 51

그래서 flex-end 썼었구나,,,
얘 이렇게 보이네요 길어지면 밑에 붙게 함 해볼게욥

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xodms0309

완료우....
근데 프로필 사진도 원래 한줄이면 가운데고, 늘어나면 밑에 붙는거긴한데 그냥 넘어가겠음니다 잘 안 보임 ^_^

스크린샷 2024-07-31 오후 11 28 26 스크린샷 2024-07-31 오후 11 28 41

width: '100%',
padding: '6px 16px 9px 16px',
padding: '6px 16px 6px 16px',
background: vars.colors.background.category,
borderRadius: 20,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const RecipeFavoriteButton = ({ recipeId, favorite, favoriteCount }: RecipeFavor
<SvgIcon variant="heartEmpty" width={24} height={24} />
</div>
)}
{favoriteCount && <div style={{ width: 6 }} />}
<Text as="span" size="caption1" weight="medium" color="sub">
{favoriteCount}
</Text>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@ import { style } from '@vanilla-extract/css';
export const container = style({
display: 'flex',
alignItems: 'center',
gap: 6,
});
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useRef } from 'react';

import { listWrapper } from './recipeSearchResultPreviewList.css';
import { container, wrapper } from './recipeSearchResultPreviewList.css';
import SearchNotFound from '../SearchNotFound/SearchNotFound';

import { ShowAllButton } from '@/components/Common';
Expand All @@ -26,9 +26,9 @@ const RecipeSearchResultPreviewList = ({ searchQuery }: RecipeSearchResultPrevie
}

return (
<ul className={listWrapper}>
<ul className={container}>
{displaySlice(false, recipes, 4).map((recipe, idx) => (
<li key={recipe.id}>
<li key={recipe.id} className={wrapper}>
{idx < 4 ? (
<DefaultRecipeItem recipe={recipe} />
) : (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
import { style } from '@vanilla-extract/css';

export const listWrapper = style({
export const container = style({
display: 'flex',
gap: 10,
alignItems: 'center',
overflowY: 'scroll',
});

export const wrapper = style({
height: '100%',
display: 'flex',
flex: '0 0 160px',
});
Loading