🐛 headless deployments need to stay public

fumeapp · Feb 25, 2024 · c2ebbdf · c2ebbdf
1 parent e407451
commit c2ebbdf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/commands/deploy.ts b/src/commands/deploy.ts
@@ -283,6 +283,9 @@ export default class Deploy extends Command {
           'dist',
           dp.deployment.s3.headless,
           'SYNC_FILES',
+          '',
+          true,
+          true,
         ),
       },
       {

diff --git a/src/lib/deploytasks.ts b/src/lib/deploytasks.ts
@@ -537,7 +537,7 @@ exports.handler = async (event, context) => {
     })
   }
 
-  async sync(task: ListrTaskWrapper<any, any> | null, folder: string, bucket: string, status: string, prefix = '', deleteRemoved = true) {
+  async sync(task: ListrTaskWrapper<any, any> | null, folder: string, bucket: string, status: string, prefix = '', deleteRemoved = true, IsHeadless = false) {
     await this.deployment.update(status)
     const sts = await this.deployment.sts()
     const client = require('@auth0/s3').createClient({s3Client: new S3(sts)})
@@ -547,7 +547,7 @@ exports.handler = async (event, context) => {
         deleteRemoved: deleteRemoved,
         s3Params: {
           Bucket: bucket,
-          ACL: 'private',
+          ACL: IsHeadless ? 'publc-read' : 'private',
           Prefix: prefix,
         },
       })
-Original file line number
+Diff line change
@@ Expand Up / @@ -283,6 +283,9 @@ export default class Deploy extends Command { @@
               'dist',
               dp.deployment.s3.headless,
               'SYNC_FILES',
+              '',
+              true,
+              true,
             ),
           },
           {
@@ Expand Down @@