Adds test for better fgoxide header error and bump fgoxide version. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theJasonFan
commented
Apr 25, 2024
| @@ -36,7 +36,9 @@ bstr = "1.0.1" | |||
| clap = { version = "4.0.25", features = ["derive"] } | |||
| enum_dispatch = "0.3.8" | |||
| env_logger = "0.9.3" | |||
| fgoxide = "0.3.0" | |||
| # TODO: change this when 0.3.1 is released with header validation. | |||
There was a problem hiding this comment.
NB: fix and squash the commit after PR is merged in fgoxide.
theJasonFan
force-pushed
the
jf/test-header-error
branch
from
df885be
to
d999943
Compare
theJasonFan
commented
Aug 19, 2024
There was a problem hiding this comment.
Adds tests to catch the new fgoxide header error Error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs: