Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #549 Propagate parent to hooks components #550

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

holyjak
Copy link
Collaborator

@holyjak holyjak commented Jan 20, 2024

Issue: The render body of hooks-based components gets its props from the use-fulcro hook, which failed to propagate fulcro$parent in the raw JS props. comp/get-parent relies on it, and thus stopped working there.

Fix: Add it to the manually tunnelled raw JS props in use-fulcro.

Issue: The render body of hooks-based components gets its props from the use-fulcro hook, which failed to propagate `fulcro$parent` in the raw JS props. comp/get-parent relies on it, and thus stopped working there.

Fix: Add it to the manually tunnelled raw JS props in use-fulcro.
@holyjak holyjak marked this pull request as draft January 20, 2024 23:50
@holyjak

This comment was marked as resolved.

@awkay awkay marked this pull request as ready for review January 21, 2024 17:24
@holyjak

This comment was marked as off-topic.

@holyjak
Copy link
Collaborator Author

holyjak commented Jan 22, 2024

Hm, the problem I found seems unrelated to this change.

@awkay awkay merged commit 7d4440a into main Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants