Mark render-to-str deprecated, show how to do it yourself #547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use proper require of react-dom/server and invoke its renderToString, instead of accessing the global js/ReactDOMServer, which might not be available.
I had troubles making sure that
js/ReactDOMServer
and thus couldn't render to a string. With this change, it works fine.BEWARE: I don't know whether the use of js/ReactDOMServer is a left-over from old times, or whether it is intentional, e.g. to make sure that we do not require
react-dom/server
if not needed. So I don't know whether this change is desirable or not.