This repository has been archived by the owner on Apr 8, 2023. It is now read-only.
[wip] Search all documents #658
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janno42
commented
Aug 20, 2018
| class Migration(migrations.Migration): | ||
|
|
||
| replaces = [('information_pages', '0004_auto_20180813_2050'), ('information_pages', '0005_auto_20180813_2102')] | ||
|
|
There was a problem hiding this comment.
this is a squashed migration although that's not necessary because both 0004 and 0005 didn't exist before. please create a plain new migration instead.
| class Migration(migrations.Migration): | ||
|
|
||
| replaces = [('minutes', '0010_auto_20180813_2050'), ('minutes', '0011_auto_20180813_2102')] | ||
|
|
| <a href="#" id="popover" data-placement="bottom"> | ||
| <span class="glyphicon glyphicon-search" aria-hidden="true"></span> | ||
| </a> | ||
| <div id="popover-content" class="hide"> |
There was a problem hiding this comment.
the indentation here is wrong
| @@ -95,6 +95,18 @@ | |||
| </ul> | |||
| </li> | |||
| {% endif %} | |||
| {# Search form #} | |||
| <li class ="pull-right"> | |||
| <a href="#" id="popover" data-placement="bottom"> | |||
There was a problem hiding this comment.
please make the popover dismissable (http://getbootstrap.com/docs/4.1/components/popovers/#dismiss-on-next-click)
| @@ -95,6 +95,18 @@ | |||
| </ul> | |||
| </li> | |||
| {% endif %} | |||
| {# Search form #} | |||
There was a problem hiding this comment.
please add some javascript that automatically focuses the search text field on opening the popover
| $('[data-toggle="popover"]').popover() | ||
| }); | ||
|
|
||
| $('#popover').popover({ |
There was a problem hiding this comment.
can you combine these two method calls into one?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopened from #656, there are some open issues here.
i will add some review comments.