Merge pull request #112 from chives/1.2

Do not try to get saved property value when there is none
fsi-open · Jul 10, 2018 · 6aa6195 · 6aa6195
2 parents 2990900 + fc98b90
commit 6aa6195
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/composer.json b/composer.json
@@ -31,6 +31,9 @@
         "doctrine/orm": "~2.4",
         "phpunit/phpunit": "3.7.*"
     },
+    "conflict": {
+        "phpunit/php-file-iterator": ">=2.0.0"
+    },
     "autoload": {
         "psr-4": {
             "FSi\\DoctrineExtensions\\": "lib/FSi/DoctrineExtensions/"

diff --git a/lib/FSi/DoctrineExtensions/Uploadable/UploadableListener.php b/lib/FSi/DoctrineExtensions/Uploadable/UploadableListener.php
@@ -395,10 +395,10 @@ protected function updateFiles(ObjectManager $objectManager, $uploadableMeta, $o
                 $filesystem = $this->computeFilesystem($config);
 
                 // Since file has changed, the old one should be removed.
-                if ($oldKey = $accessor->getValue($object, $property)) {
-                    if ($oldFile = $propertyObserver->getSavedValue($object, $config['targetField'])) {
-                        $this->addToDelete($oldFile);
-                    }
+                if ($accessor->getValue($object, $property)
+                    && $propertyObserver->hasSavedValue($object, $config['targetField'])
+                    && $oldFile = $propertyObserver->getSavedValue($object, $config['targetField'])) {
+                    $this->addToDelete($oldFile);
                 }
 
                 if (empty($file)) {