Enhanced README, Enhanced promiseFiles, Added options.shortName='relative' #43
Conversation
…nc, promiseFiles type is optional
|
Additional tests have also been included |
|
Let me know if I can help any further. Looking for action on this so I might use node-dir from NPM. Do hope this time of year is a pleasant one for you and those around you. Working hard myself but looking forward to putting down the keyboard for the very close of this year. |
|
+1 for a quick npm publish...we're linking to the latest commits in our package.json to get the promises :) |
|
@fshost, hope all is well. Anyway that we can help get this pull request accepted and added to npm? We've had to build training documentation on using node-dir but pulling code from my fork: https://github.com/AckerApple/node-dir Please help make life easier for everyone, please accept this pull request. |
|
Sorry for taking so long. I've been really tied up with stuff that pays the bills. I need to resolve this and test it. I hope I can get it done soon. Thanks for your patience. |
|
I have merged the conflicts to the best of my ability and then tested. Lets keep this ball rolling in motion. And hey, I know what you mean by "stuff that pays the bills" but I'm trying to pay the bills using your package. So do help me out, lets get this pull request released to npm. |
|
My pull request has 153 Clones, 96 Unique cloners. People are using it. On npm, node-dir had 855,558 downloads in the last month. Your face is getting seen on the NPM page. Please help me, help you, publish this pull request. I have my own NPM packages, that have the dependency as this pull request, I really want to fix that. I really really really don't want to republish my pull request as a different named package, no reason to have two packages doing the same thing. Plus you have a better looking face for NPM visitors to see and we should keep it that way. Please, in the most kindest way, pull and npm publish. Thank you much. |
README.md
Outdated
|
|
||
| // exclude an array of subdirectory names | ||
| Exclude an array of subdirectory names | ||
| ``` | ||
| dir.readFiles(__dirname, { | ||
| exclude: ['node_modules', 'test'] |
There was a problem hiding this comment.
This is a typo in the current README: the option to exclude directories is excludeDir, not exclude.
|
Added Windows testing via ci.appveyor.com . Upgraded Travis to test more versions of node. |
Create CODE_OF_CONDUCT.md
Create CODE_OF_CONDUCT.md
|
Ignore code of conduct commits |
fixed strange problem with webpack.
|
We miss you @fshost ! But we've moved on. My fork of node-dir has been renamed to path-reader and published to npm. We do hope all is well otherwise. |
Thank you kindly!