update attributes naming for text modifier #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaiido
reviewed
Oct 21, 2021
| @@ -49,7 +49,7 @@ Example usage | |||
| const canvas = document.createElement('canvas'); | |||
| const ctx = canvas.getContext('2d'); | |||
|
|
|||
| ctx.textLetterSpacing = "3px"; | |||
| ctx.letterSpacing = "3px"; | |||
There was a problem hiding this comment.
In the HTML specs letterSpacing is defined as a double.
Does Chrome's implementation diverge?
There was a problem hiding this comment.
We will be changing the spec to reflect this.
We believe it's better for letterSpacing/wordspacing to take string, so users can use different length units.
There was a problem hiding this comment.
Oh really? That's quite surprising, I can also see the argument that playing with numbers is more useful for canvas applications, font is already a pain point because we have to build a string from all weight, size and name.
But the PR with this change will be a better place to discuss this.
Good to see it wasn't an oversight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the TAG review, we decided to change textLetterSpacing to letterSpacing and textWordSpacing to workSpacing.