Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority for phpenmod #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Priority for phpenmod #48

wants to merge 1 commit into from

Conversation

luckyraul
Copy link

Priority param for clean integration with phpenmod

@maxenced
Copy link

+1 , without this, using this module lead to 2 files in php conf dir : newrelic.ini and 20-newrelic.ini

@baurmatt
Copy link

This is really important. Please merge as soon as possible!

@baurmatt
Copy link

baurmatt commented Oct 6, 2016

Digged some more into it. There is also an issue with this line:

command  => "/usr/bin/newrelic-install purge ; NR_INSTALL_SILENT=yes, NR_INSTALL_KEY=${php::newrelic::license_key} /usr/bin/newrelic-install install",

The problem is the following:

  • newrelic-php5 gets installed and adds (e.g) /etc/php5/mods-available/newrelic.ini with a symlink /etc/php5/apache2/conf.d/20-newrelic.ini
  • newrelic-install gets executed and creates /etc/php5/apache2/conf.d/newrelic.ini without deleting the already created files.

I think the best option is to remove the newrelic-install command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants