Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore package-lock.json #1181

Closed
wants to merge 1 commit into from
Closed

Conversation

rubo77
Copy link
Contributor

@rubo77 rubo77 commented Sep 5, 2023

This file should not be within the git repository, since it is automatically edited, when you run the install instructions:

composer install --no-dev
npm install
npm run build

@d00p
Copy link
Member

d00p commented Sep 5, 2023

same as composer.lock, it represents the package versions installed/tested for a release and thus used for building the release packages (instead of package.json).

Also relevant for developers: It allows future devs to install the same dependencies in the project.

@d00p d00p closed this Sep 5, 2023
@rubo77
Copy link
Contributor Author

rubo77 commented Sep 6, 2023

Ah ok. So would you like to see the changes to the file, that were automatically made in my repository, and update the file then?

@d00p
Copy link
Member

d00p commented Sep 6, 2023

You obviously don't understand and rather discuss meaningless on GitHub then talk to us on discord.

@discordier
Copy link
Contributor

For the record, install as follows:

composer install --no-dev
npm ci
npm run build

See https://docs.npmjs.com/cli/v9/commands/npm-ci

That way you get the dependencies as intended.

npm install is for developers that want to get current dependencies.

@rubo77 rubo77 deleted the ignore_package-lock branch September 7, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants