BREAKING CHANGE: use glob patterns for package identification #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGiantSquid
force-pushed
the
add-support-for-wildcard-package-paths
branch
from
7a07647
to
f87adfa
Compare
frostming
reviewed
Aug 16, 2023
|
Sorry for getting to this late. It has been lost in my radar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monas currently expects the top level config to contain a "packages" field that contains the relative path of the directory that contains python packages.
This changes the field to look for glob patterns that point to python package directories instead. This makes it behave more like Lerna, the inspiration for this project.
It also allows for the root directory to contain a project, which solves this problem: #12
This also gives user the flexibility to do something like
if they wanted to be specific about which directories monas should look inside.