Skip to content
This repository has been archived by the owner on Jan 8, 2023. It is now read-only.

Add section component #53

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Add section component #53

merged 2 commits into from
Nov 8, 2022

Conversation

wralith
Copy link
Contributor

@wralith wralith commented Nov 7, 2022 •
edited
Loading

#27

  • It expect padding values with their units: (i.e. 1rem, 24px) Can be arranged with app level standarts in the future.
  • Same result will be achieved by leveraging tailwind utility classes with conditionals.

9ssi7
9ssi7 suggested changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@9ssi7 9ssi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things that are not compatible with the project. Please fix them

components/Section/Section.tsx Outdated Show resolved Hide resolved
components/Section/Section.tsx Outdated Show resolved Hide resolved
components/Section/Section.tsx Outdated Show resolved Hide resolved
@wralith wralith requested a review from 9ssi7 November 8, 2022 14:08
@9ssi7
Copy link
Collaborator

9ssi7 commented Nov 8, 2022

LGTM!

@9ssi7 9ssi7 merged commit 10af475 into frontendship:main Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@9ssi7 9ssi7 Awaiting requested review from 9ssi7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wralith @9ssi7