Rfc9293 WIP #202
Open
Rfc9293 WIP #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:ack-p t is the default.
TCP specification (rfc9293) says to send a reset segment
Make sure the Mezzano compilation does not fail due to missing :closed case
fitzsim
previously approved these changes
Jul 14, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fitzsim
reviewed
Jul 14, 2024
fitzsim
dismissed
their stale review
Thought this would apply commit-by-commit, not to every single commit in the whole pull request.
fitzsim
reviewed
Jul 14, 2024
fitzsim
reviewed
Jul 14, 2024
fitzsim
reviewed
Jul 14, 2024
| @@ -379,6 +379,7 @@ Set to a value near 2^32 to test SND sequence number wrapping.") | |||
| (when (not *netmangler-force-local-retransmit*) | |||
| (tcp4-send-packet connection iss (+u32 irs 1) nil :syn-p t)))) | |||
| ((logtest flags +tcp4-flag-rst+)) ; Do nothing for resets addressed to nobody. | |||
| ((logtest flags +tcp4-flag-fin+)) ; Do nothing for finish since the SEG.SEQ cannot be validated | |||
There was a problem hiding this comment.
Do you have a way to test this?
fitzsim
reviewed
Jul 14, 2024
fitzsim
reviewed
Jul 14, 2024
fitzsim
reviewed
Jul 14, 2024
fitzsim
reviewed
Jul 14, 2024
fitzsim
reviewed
Jul 14, 2024
fitzsim
reviewed
Jul 14, 2024
| @@ -760,8 +760,10 @@ to wrap around logic" | |||
| (challenge-ack connection))) | |||
| ((logtest flags +tcp4-flag-syn+) | |||
| (challenge-ack connection)) | |||
| ((logtest flags +tcp4-flag-ack+) | |||
| (detach-tcp-connection connection)))) | |||
| ((not (logtest flags +tcp4-flag-ack+))) ; Ignore packets without ACK set. | |||
There was a problem hiding this comment.
Typo in the commit message for this one. Not commenting on the logic in the change.
fitzsim
reviewed
Jul 14, 2024
| @@ -763,7 +763,11 @@ to wrap around logic" | |||
| ((not (logtest flags +tcp4-flag-ack+))) ; Ignore packets without ACK set. | |||
| (t | |||
| (when (eql ack (tcp-connection-snd.nxt connection)) | |||
| (detach-tcp-connection connection))))) | |||
| (detach-tcp-connection connection)) | |||
There was a problem hiding this comment.
Another typo in this commit message.
fitzsim
reviewed
Jul 14, 2024
| @@ -709,8 +709,8 @@ to wrap around logic" | |||
| (tcp4-send-packet connection ack seq nil :ack-p nil :rst-p t))) | |||
| (when (and (logtest flags +tcp4-flag-fin+) | |||
| (eql seq (tcp-connection-rcv.nxt connection))) | |||
| (setf (tcp-connection-rcv.nxt connection) (+u32 seq 1) | |||
| (tcp-connection-state connection) :close-wait) | |||
| (setf (tcp-connection-state connection) :close-wait | |||
There was a problem hiding this comment.
Typo in commit message: "resive".
fitzsim
reviewed
Jul 14, 2024
| @@ -130,7 +130,7 @@ Returns NIL if there is no entry currently in the cache, this will trigger a loo | |||
| nil) | |||
|
|
|||
| (defun arp-expiration () | |||
| (let ((time (1+ (get-internal-real-time)))) | |||
| (let ((time (1+ (get-universal-time)))) | |||
There was a problem hiding this comment.
Is it an option to use internal-real-time throughout arp.lisp instead? Is get-universal-time monotonic, or can it change backwards when setting the system date/time (in which case it should not be used for ARP timeouts).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.