Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracer: Bind UI to a random port #170

Merged
merged 2 commits into from
Oct 19, 2024
Merged

tracer: Bind UI to a random port #170

merged 2 commits into from
Oct 19, 2024

Conversation

ChiChou
Copy link
Contributor

@ChiChou ChiChou commented Oct 18, 2024

Let the OS to choose an idle port instead of iteration and retry

@ChiChou
Copy link
Contributor Author

ChiChou commented Oct 18, 2024

But there seems to be a race condition...

self._ui_port is shared between two threads, we can not guarantee on_trace_progress happends after websocket server initialization

@ChiChou ChiChou force-pushed the randport branch 3 times, most recently from e608c7f to 8d3ce35 Compare October 18, 2024 21:53
Copy link
Member

@oleavr oleavr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please reformat the commit messages to follow the existing style? E.g. tracer: Capitalized summary, loosely based on https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html.

@oleavr
Copy link
Member

oleavr commented Oct 18, 2024

But there seems to be a race condition...

self._ui_port is shared between two threads, we can not guarantee on_trace_progress happends after websocket server initialization

Glad you saw this. I did this intentionally as a temporary hack, but then forgot to fix it 😅

@ChiChou ChiChou requested a review from oleavr October 18, 2024 22:55
@ChiChou ChiChou changed the title bind UI to a random port tracer: Bind UI to a random port Oct 18, 2024
@oleavr oleavr merged commit 03236f2 into frida:main Oct 19, 2024
3 checks passed
@ChiChou ChiChou deleted the randport branch October 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants