Added get_device_by_id to the device_manager and example #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1341
approved these changes
Dec 13, 2023
|
@iteroji please see the CI error. The test cannot be run on CI. |
I had invalid characters in rust doc causing doc test to fail. Updated it, now all tests should pass |
|
Needs a |
|
And now clippy is complaining :( |
At least now I know what checks to run before PR :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a convenience method to get a device by its identifier. This is most useful if you have multiple USB or network devices attached and want to work with a specific one without having to enumerate all and find the one by id.
Created a simple example that demonstrates the usage of the
get_device_by_typeandget_device_by_idmethods.