Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a couple of useful features to Device #110

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Add a couple of useful features to Device #110

merged 3 commits into from
Nov 14, 2023

Conversation

fabianfreyer
Copy link
Contributor

@fabianfreyer fabianfreyer commented Sep 18, 2023 •
edited
Loading

I needed these things, so here they are. If you'd rather have self-contained PR's, happy to do that too,.

Would be really cool to get these into a 0.14 release!

@fabianfreyer
Copy link
Contributor Author

46d9dda will probably conflict with #108, so whichever gets merged last should use the other's DeviceType struct.

@fabianfreyer fabianfreyer force-pushed the feat/device-features branch 7 times, most recently from 25588e6 to 29748d5 Compare September 18, 2023 15:57
@meme
Copy link
Collaborator

meme commented Sep 18, 2023 •
edited
Loading

LGTM. Please look into the Windows build failures. Thanks.

@fabianfreyer
Copy link
Contributor Author

@meme done, and rebased.

@meme
Copy link
Collaborator

meme commented Oct 11, 2023

Please resolve the conflicts so I can merge. Thanks again, apologies for the delay.

@fabianfreyer
Copy link
Contributor Author

fabianfreyer commented Oct 14, 2023 •
edited
Loading

Please resolve the conflicts so I can merge. Thanks again, apologies for the delay.

done. I've merged my DeviceType implementations into @csnewman's (#108), in an AFACT backwards-compatible way.

meme
meme previously approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@meme meme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@meme
Copy link
Collaborator

meme commented Oct 14, 2023

Looks like checks are still failing.

@fabianfreyer
Copy link
Contributor Author

Oh, looks like I didn't run rustfmt on each commit. Fixed that, sorry!

meme
meme requested changes Oct 20, 2023
View reviewed changes
frida/src/variant.rs Outdated Show resolved Hide resolved
@fabianfreyer
feat(device): Add method to query system params
fd259c6 
This requires some GVariant handling which was mostly inspired by the
implementation in frida-go's types_converter.go.
@fabianfreyer
feat(device): Add a getter for the device type
30c6b5f
@fabianfreyer
feat(device): Add spawn/resume methods
67d73b9
@fabianfreyer
Copy link
Contributor Author

@meme ping?

@meme meme merged commit a31c6eb into frida:main Nov 14, 2023
15 checks passed
@fabianfreyer
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meme meme meme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfreyer @meme