Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _ZNK3art6Thread13DecodeJObjectEP8_jobject optional #289

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

gsingh93
Copy link
Contributor

This will fix frida/frida#2468

@gsingh93
Copy link
Contributor Author

As this is only used for Android 6 and lower, I think making it optional makes sense instead of having a fallback.

And as a sidenote, I think the current system of looking for these methods is prone to break often. I would suggest instead of attempting to find every method not marked as optional, we just find the version of android we're connecting to, and then have a list of APIs that were added/removed from each version. Then, if we have an API in the "removed" list for Android 7, it will still be required for Android 6 and lower, but not required for anything above Android 6.

@gsingh93
Copy link
Contributor Author

@oleavr can you run the checks that require approval?

@AAGaming00

This comment was marked as resolved.

@gsingh93
Copy link
Contributor Author

gsingh93 commented May 24, 2023

The build instructions are the normal ones for Frida, except to use the local version of frida-java-bridge I had to make this modification to frida-gum: gsingh93/frida-gum@dabfe43

I've asked in #288 what the right way to use a local version of this library is.

@oleavr oleavr merged commit dd6f779 into frida:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing: _ZNK3art6Thread13DecodeJObjectEP8_jobject
3 participants