Fix: Stalker disrupts exclusive access by emitting a block event. #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stalker generates the block event even when those blocks have exclusive access. This may disrupt the exclusive access when a user handles the block event. It seems that the default stalker event sinker uses spinlocks, which can starve the following thread.
|
Thanks, great catch! 🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stalker generates the block event even when those blocks have exclusive access. This may disrupt the exclusive access when a user handles the block event.
It seems that the default stalker event sinker uses spinlocks, which can starve the following thread.
check this issue