Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Memory.queryProtection() #779

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Add Memory.queryProtection() #779

merged 4 commits into from
Feb 13, 2024

Conversation

mrmacete
Copy link
Contributor

This change adds gum_memory_query_protection which takes an address and returns the current protection for the page which contains it.

It is accessible from js bindings through Memory.queryProtection().

On the Darwin backend it's a thin wrapper on top of gum_darwin_query_protection, on all other platforms it relies instead on the respective private implementations of gum_memory_get_protection.

@mrmacete mrmacete marked this pull request as draft January 26, 2024 20:48
@mrmacete mrmacete changed the title Add Memory.queryProtection() WIP: Add Memory.queryProtection() Jan 26, 2024
Copy link
Member

@oleavr oleavr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t! 💥

bindings/gumjs/gumquickmemory.c Outdated Show resolved Hide resolved
bindings/gumjs/gumv8memory.cpp Show resolved Hide resolved
bindings/gumjs/gumv8memory.cpp Outdated Show resolved Hide resolved
@mrmacete mrmacete force-pushed the feature/memory-query-protection branch from 1135e8b to 1d9338f Compare January 30, 2024 16:27
@mrmacete mrmacete marked this pull request as ready for review January 30, 2024 16:34
@mrmacete mrmacete changed the title WIP: Add Memory.queryProtection() Add Memory.queryProtection() Jan 30, 2024
mrmacete and others added 3 commits February 12, 2024 14:21
This change adds `gum_memory_query_protection` which takes an address
and returns the current protection for the page which contains it.

It is accessible from js bindings through `Memory.queryProtection()`.

On the Darwin backend it's a thin wrapper on top of
`gum_darwin_query_protection`, on all other platforms it relies instead
on the respective private implementations of `gum_memory_get_protection`.
@oleavr oleavr force-pushed the feature/memory-query-protection branch from 1d9338f to 7054eac Compare February 12, 2024 13:21
@oleavr
Copy link
Member

oleavr commented Feb 12, 2024

CI is finally in better shape, sorry it took so long! 😅 Only one style issue left and this is ready to merge 🚀

Copy link
Member

@oleavr oleavr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged 🤘🏻

bindings/gumjs/gumquickmemory.c Outdated Show resolved Hide resolved
@oleavr oleavr merged commit 1af4f83 into main Feb 13, 2024
31 of 32 checks passed
@oleavr oleavr deleted the feature/memory-query-protection branch February 13, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants