Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloak module #771

Merged
merged 7 commits into from
Jan 20, 2024
Merged

Add Cloak module #771

merged 7 commits into from
Jan 20, 2024

Conversation

mrmacete
Copy link
Contributor

This change adds the Cloak module, exposing the add / remove / query apis from gumcloak.h. This module is exposed to the Worker too.

There are 2 more loosely related changes:

  • add a missing call to gum_cloak_add_range in Interceptor to cloak the thunks on arm64
  • fix the docs of gum_cloak_clip_range to describe the actual semantics of the return value

@mrmacete mrmacete force-pushed the feature/add-cloak-module branch from 13c3ecc to a2a4d63 Compare January 15, 2024 07:54
@mrmacete mrmacete requested a review from oleavr January 15, 2024 07:54
@mrmacete mrmacete force-pushed the feature/add-cloak-module branch from a2a4d63 to 5024e1e Compare January 15, 2024 08:52
@oleavr oleavr force-pushed the feature/add-cloak-module branch from 5024e1e to 111a8bd Compare January 17, 2024 13:12
@mrmacete mrmacete force-pushed the feature/add-cloak-module branch 5 times, most recently from ddc768b to 994d2df Compare January 19, 2024 13:19
Copy link
Member

@oleavr oleavr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t! 🤘

bindings/gumjs/gumquickcloak.c Show resolved Hide resolved
bindings/gumjs/gumquickcloak.c Outdated Show resolved Hide resolved
@mrmacete mrmacete force-pushed the feature/add-cloak-module branch from 994d2df to 7d20721 Compare January 19, 2024 16:24
@mrmacete
Copy link
Contributor Author

lol i broke tests again, checking

@mrmacete mrmacete force-pushed the feature/add-cloak-module branch from 66080bb to fb28fe8 Compare January 19, 2024 17:37
@oleavr oleavr force-pushed the feature/add-cloak-module branch from fb28fe8 to caafcc1 Compare January 19, 2024 23:38
@oleavr oleavr merged commit 3dc1415 into main Jan 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants