interceptor: Add note about protection flipping on RWX systems

frida · May 10, 2024 · 7d9e1a4 · 7d9e1a4
1 parent 071eccf
commit 7d9e1a4
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/gum/guminterceptor.c b/gum/guminterceptor.c
@@ -1103,6 +1103,13 @@ gum_interceptor_transaction_end (GumInterceptorTransaction * self)
 
       if (!rwx_supported)
       {
+        /*
+         * We don't bother restoring the protection on RWX systems, as we would
+         * have to determine the old protection to be able to do so safely.
+         *
+         * While we could easily do that, it would add overhead, but it's not
+         * really clear that it would have any tangible upsides.
+         */
         for (cur = addresses; cur != NULL; cur = cur->next)
         {
           gpointer target_page = cur->data;