gumjs: Reply with undefined when RPC method returns binary data

Instead of an empty object. This isn't used by clients, so this is only for semantic consistency with a method not returning any value. Co-authored-by: Håvard Sørbø <[email protected]>
frida · May 31, 2024 · 52fa04d · 52fa04d
1 parent b47d3c3
commit 52fa04d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/bindings/gumjs/runtime/message-dispatcher.js b/bindings/gumjs/runtime/message-dispatcher.js
@@ -71,7 +71,7 @@ function MessageDispatcher() {
     params = params || [];
 
     if (result instanceof ArrayBuffer)
-      send(['frida:rpc', id, type, {}].concat(params), result);
+      send(['frida:rpc', id, type, undefined].concat(params), result);
     else
       send(['frida:rpc', id, type, result].concat(params));
   }

diff --git a/tests/gumjs/script.c b/tests/gumjs/script.c
@@ -6068,7 +6068,7 @@ TESTCASE (method_can_return_binary_data)
           "return buf.readByteArray(2);"
       "};");
   POST_MESSAGE ("[\"frida:rpc\",42,\"call\",\"read\",[]]");
-  EXPECT_SEND_MESSAGE_WITH_PAYLOAD_AND_DATA ("[\"frida:rpc\",42,\"ok\",{}]",
+  EXPECT_SEND_MESSAGE_WITH_PAYLOAD_AND_DATA ("[\"frida:rpc\",42,\"ok\",null]",
       "59 6f");
 }