Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4 migration #2175

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

v4 migration #2175

wants to merge 7 commits into from

Conversation

enddynayn
Copy link
Collaborator

@enddynayn enddynayn commented Oct 4, 2024 •
edited
Loading

Goal

The goal of this PR is 

cargo build --features frequency-testnet,try-runtime && \
try-runtime --runtime ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm on-runtime-upgrade live --uri wss://rpc.testnet.amplica.io:443 -pallet  Capacity --pallet

#1920
#2141
#2141

Discussion

Checklist

  • Updated Pallet Readme?
  • Updated js/api-augment for Custom RPC OR Runtime API?
  • Design doc(s) updated?
  • Unit Tests added?
  • e2e Tests added?
  • Benchmarks added?
  • Spec version incremented?

@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pallets/capacity/src/migration/v4.rs 92.85% 2 Missing ⚠️
Files with missing lines Coverage Δ
pallets/capacity/src/lib.rs 95.34% <ø> (ø)
pallets/capacity/src/migration/v4.rs 92.85% <92.85%> (ø)

@enddynayn enddynayn changed the title v3 migration v4 migration Oct 4, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Oct 4, 2024
@enddynayn enddynayn force-pushed the feat/update-frequency-mainnet-to-6-second-blocks-issue-1920 branch from 2843ab9 to 2d492e5 Compare October 4, 2024 17:35
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Oct 4, 2024
@enddynayn enddynayn force-pushed the feat/update-frequency-mainnet-to-6-second-blocks-issue-1920 branch from 2d492e5 to 7814837 Compare October 4, 2024 18:23
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Oct 4, 2024
@enddynayn enddynayn force-pushed the feat/update-frequency-mainnet-to-6-second-blocks-issue-1920 branch from 7814837 to 4dbb987 Compare October 4, 2024 19:58
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Oct 4, 2024
@enddynayn enddynayn force-pushed the feat/update-frequency-mainnet-to-6-second-blocks-issue-1920 branch 2 times, most recently from c5aab23 to ffba7bb Compare October 4, 2024 20:30
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Oct 4, 2024
@enddynayn enddynayn mentioned this pull request Oct 4, 2024
Open
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Oct 4, 2024
@enddynayn enddynayn force-pushed the feat/update-frequency-mainnet-to-6-second-blocks-issue-1920 branch from 611774e to 427035b Compare October 4, 2024 22:44
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Oct 4, 2024
@enddynayn
v4 capacity migration
b041704 
updates to migration
@enddynayn
Update max epoch length to two days, assuming 6-second block times. T…
13069a1 
…his adjustment allows flexibility for future proposals to extend the epoch length in case of decreased in the time it takes for collators to produce a block.
@enddynayn
6 second blocks
19992d4 
update constants
@enddynayn
update consts to use days
5c7d595
@enddynayn
update interval sealing to 6sec
34dc433
@enddynayn
fix test
3e5489a
@enddynayn
spec version
e49783e
@enddynayn enddynayn force-pushed the feat/update-frequency-mainnet-to-6-second-blocks-issue-1920 branch from 9534691 to e49783e Compare October 4, 2024 22:47
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilwade wilwade Awaiting requested review from wilwade wilwade will be requested when the pull request is marked ready for review wilwade is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@enddynayn