Exception: display inner exceptions

Closes #64
fremag · Feb 7, 2016 · 6ed5e71 · 6ed5e71
1 parent 0ab529c
commit 6ed5e71
Show file tree

Hide file tree

Showing 5 changed files with 149 additions and 30 deletions.
diff --git a/MemoDummy/ExceptionThreadScript.cs b/MemoDummy/ExceptionThreadScript.cs
@@ -1,6 +1,8 @@
 using System.ComponentModel;
 using System.Threading;
 using System;
+using System.Diagnostics;
+
 namespace MemoDummy
 {
     public class ExceptionThreadScript : AbstractMemoScript
@@ -15,7 +17,22 @@ public override void Run()
         {
             for(int i=0; i < NbThreads; i++)
             {
-                Thread thread = new Thread(() => { throw new IndexOutOfRangeException(); });
+                Thread thread = new Thread(() =>
+                {
+                    int[] arrayInt = new int[5];
+                    try
+                    {
+                        int x = arrayInt[arrayInt.Length];
+                        if( x < 0)
+                        {
+                            Debug.WriteLine("Huh ?");
+                        }
+                    }
+                    catch (Exception e)
+                    {
+                        throw new Exception("Something failed !", e);
+                    }
+                });
                 thread.Name = "thread #" + i;
                 thread.Start();
             }

diff --git a/MemoScope/MemoScope.csproj b/MemoScope/MemoScope.csproj
@@ -191,6 +191,7 @@
     <Compile Include="Modules\DumpDiff\DiffColumn.cs">
       <SubType>Component</SubType>
     </Compile>
+    <Compile Include="Modules\ThreadException\ClrExceptionInformation.cs" />
     <Compile Include="Modules\ThreadException\ThreadExceptionCommand.cs" />
     <Compile Include="Modules\ThreadException\ThreadExceptionModule.cs">
       <SubType>UserControl</SubType>

diff --git a/MemoScope/Modules/ThreadException/ClrExceptionInformation.cs b/MemoScope/Modules/ThreadException/ClrExceptionInformation.cs
@@ -0,0 +1,28 @@
+using BrightIdeasSoftware;
+using MemoScope.Core;
+using MemoScope.Modules.StackTrace;
+using Microsoft.Diagnostics.Runtime;
+using System.Collections.Generic;
+using System.Linq;
+
+namespace MemoScope.Modules.ThreadException
+{
+    public class ClrExceptionInformation 
+    {
+        [OLVColumn(Width=450)]
+        public string TypeName { get; }
+        [OLVColumn(Width = 500)]
+        public string Message { get; }
+
+        public List<StackFrameInformation> StackFrames { get; }
+        private ClrException exception;
+
+        public ClrExceptionInformation(ClrDump clrDump, ClrException exception)
+        {
+            this.exception = exception;
+            Message = clrDump.Eval(() => exception.Message);
+            StackFrames = clrDump.Eval(() => exception.StackTrace.Select(frame => new StackFrameInformation(clrDump, frame))).ToList();
+            TypeName = exception.Type.Name;
+        }
+    }
+}
diff --git a/MemoScope/Modules/ThreadException/ThreadExceptionModule.Designer.cs b/MemoScope/Modules/ThreadException/ThreadExceptionModule.Designer.cs
diff --git a/MemoScope/Modules/ThreadException/ThreadExceptionModule.cs b/MemoScope/Modules/ThreadException/ThreadExceptionModule.cs
@@ -1,14 +1,14 @@
 using MemoScope.Core;
 using MemoScope.Modules.StackTrace;
 using Microsoft.Diagnostics.Runtime;
-using System.Linq;
 using System.Collections.Generic;
+using MemoScope.Core.Helpers;
 
 namespace MemoScope.Modules.ThreadException
 {
     public partial class ThreadExceptionModule : UIClrDumpModule
     {
-        public ClrException Exception { get; private set; }
+        public List<ClrExceptionInformation> Exceptions { get; private set; }
         private ClrThread ClrThread { get; set; }
         private string Message { get; set; }
         private List<StackFrameInformation> StackFrames { get; set; }
@@ -17,6 +17,7 @@ public ThreadExceptionModule()
         {
             InitializeComponent();
             dlvStackTrace.InitColumns<StackFrameInformation>();
+            dlvExceptions.InitColumns<ClrExceptionInformation>();
         }
 
         public void Setup(ClrDump clrDump, ClrThread clrThread)
@@ -30,17 +31,36 @@ public void Setup(ClrDump clrDump, ClrThread clrThread)
         public override void PostInit()
         {
             base.PostInit();
-            Summary = $"Id: {ClrThread.ManagedThreadId} : {Message}";
-            tbExceptionType.Text = Exception.Type.Name;
-            tbMessage.Text = Message;
-            dlvStackTrace.Objects = StackFrames;
+            Summary = $"Id: {ClrThread.ManagedThreadId} : {Exceptions.Count} exceptions";
         }
 
         public override void Init()
         {
-            Exception = ClrDump.Eval(() => ClrThread.CurrentException);
-            Message = ClrDump.Eval(() => Exception.Message);
-            StackFrames = ClrDump.Eval( () => Exception.StackTrace.Select(frame => new StackFrameInformation(ClrDump, frame))).ToList();
+            Exceptions = new List<ClrExceptionInformation>();
+            ClrException exception =  ClrDump.Eval(() => ClrThread.CurrentException);
+            while(exception != null)
+            {
+                Exceptions.Add(new ClrExceptionInformation(ClrDump, exception));
+                exception = ClrDump.Eval(() => exception.Inner);
+            }
+
+            dlvExceptions.Objects = Exceptions;
+        }
+
+        private void dlvExceptions_SelectedIndexChanged(object sender, System.EventArgs e)
+        {
+            var exception = dlvExceptions.SelectedObject<ClrExceptionInformation>();
+            if( exception != null)
+            {
+                Init(exception);
+            }
+        }
+
+        private void Init(ClrExceptionInformation exception)
+        {
+            tbExceptionType.Text = exception.TypeName;
+            tbMessage.Text = exception.Message;
+            dlvStackTrace.Objects = exception.StackFrames;
         }
     }
 }