feat(cd-service): delete deprecated metrics #2095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogo-nogueira-freiheit
added a commit
that referenced
this pull request
Nov 12, 2024
The following metrics in the cd-service were renamed: * `env_lock_count` > `environment_lock_count` * `app_lock_count` > `application_lock_count` While the new metrics were created the old ones are still present to avoid a breaking change. The PR that will remove these old metrics, thus introducing a breaking change is [here](#2095). The `UpdateDatadogMetrics` function is now independent of the manifest repo. Ref: SRX-EOXNZ3
diogo-nogueira-freiheit
changed the title
sven-urbanski-freiheit-com
approved these changes
Nov 13, 2024
…ror or a shutdown signal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: SRX-EOXNZ3
BREAKING CHANGE: The datadog metrics
env_lock_countandapp_lock_counthave been removed from the cd-service.In PR #2092 two metrics were deprecated. This PR removes them from kuberpult, introducing a breaking change.