fix(db): fixed function InsertAppFun function override & cleaned up update of lightweight apps on overview #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguel-crespo-fdc
changed the title
miguel-crespo-fdc
changed the title
sven-urbanski-freiheit-com
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InserAppFun was only getting overridden when we performed custom migrations. This led to a bug where when we initiated a kuberpult instance without performing migrations (i.e. normal dev-env deployment or make kuberpult locally), we would add an InsertAppFun that did not update the overview.
Also added sql migration for deleting the old overview cache.
Ref: SRX-ZYK5HN