fix: reduce number of queries to get releases #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven-urbanski-freiheit-com
force-pushed
the
su-releases-batch
branch
from
4449624
to
cb5cb59
Compare
|
I don't think the manifests are actually used in this code path. Can we skip loading them them? |
AminSlk
reviewed
Oct 10, 2024
This reduces the number of queries to the releases table, roughly by a factor of 25 (average number of releases per app). Ref: SRX-LEIHOZ
sven-urbanski-freiheit-com
force-pushed
the
su-releases-batch
branch
from
ddd932a
to
70e96fb
Compare
AminSlk
approved these changes
Oct 10, 2024
Indeed we can. I found a few more places where we load the manifest for no good reason and disabled loading them there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of queries to the releases table, roughly by a factor of 25 (average number of releases per app).
This also reduces the number of cases where we actually load all the manifests from the releases table.
And it fixes a few tests that had a nil context.
Ref: SRX-LEIHOZ