version not deployed fix

freiheit-com · Oct 24, 2024 · 5e2423e · 5e2423e
1 parent be81ff9
commit 5e2423e
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 7 deletions.
diff --git a/services/cd-service/pkg/service/overview.go b/services/cd-service/pkg/service/overview.go
@@ -57,7 +57,7 @@ type OverviewServiceServer struct {
 func (o *OverviewServiceServer) GetAppDetails(
 	ctx context.Context,
 	in *api.GetAppDetailsRequest) (*api.GetAppDetailsResponse, error) {
-	
+
 	span, ctx := tracer.StartSpanFromContext(ctx, "GetAppDetails")
 	defer span.Finish()
 

diff --git a/services/frontend-service/src/ui/Pages/Home/Home.tsx b/services/frontend-service/src/ui/Pages/Home/Home.tsx
@@ -26,7 +26,9 @@ export const Home: React.FC = () => {
     const teamsParam = (params.get('teams') || '').split(',').filter((val) => val !== '');
 
     const searchedApp = useApplicationsFilteredAndSorted(teamsParam, hideWithoutWarnings(params), appNameParam);
+
     const apps = Object.values(searchedApp);
+
     const element = useGlobalLoadingState();
     if (element) {
         return element;

diff --git a/services/frontend-service/src/ui/components/ReleaseDialog/ReleaseDialog.tsx b/services/frontend-service/src/ui/components/ReleaseDialog/ReleaseDialog.tsx
@@ -108,7 +108,7 @@ export type EnvironmentListItemProps = {
 };
 
 type CommitIdProps = {
-    deployment: Deployment;
+    deployment: Deployment | undefined;
     app: string;
     env: Environment;
     otherRelease?: Release;
@@ -290,9 +290,7 @@ export const EnvironmentListItem: React.FC<EnvironmentListItemProps> = ({
                             '. ' +
                             (release.undeployVersion ? undeployTooltipExplanation : '')
                         }>
-                        {deployment && (
-                            <DeployedVersion app={app} env={env} deployment={deployment} otherRelease={otherRelease} />
-                        )}
+                        <DeployedVersion app={app} env={env} deployment={deployment} otherRelease={otherRelease} />
                     </div>
                     {queueInfo}
                     <div className={classNames('env-card-data')}>

diff --git a/...rontend-service/src/ui/components/ReleaseDialog/__snapshots__/ReleaseDialog.test.tsx.snap b/...rontend-service/src/ui/components/ReleaseDialog/__snapshots__/ReleaseDialog.test.tsx.snap
@@ -226,7 +226,16 @@ exports[`Release Dialog Renders the environment locks normal release 1`] = `
                       <div
                         class="env-card-data"
                         title="Shows the version that is currently deployed on prod. "
-                      />
+                      >
+                        <span>
+                          "
+                          test1
+                          " has no version deployed on "
+                          prod
+                          "
+                        </span>
+                        )
+                      </div>
                       <div
                         class="env-card-data"
                       >
@@ -530,7 +539,16 @@ exports[`Release Dialog Renders the environment locks normal release with deploy
                       <div
                         class="env-card-data"
                         title="Shows the version that is currently deployed on prod. "
-                      />
+                      >
+                        <span>
+                          "
+                          test1
+                          " has no version deployed on "
+                          prod
+                          "
+                        </span>
+                        )
+                      </div>
                       <div
                         class="env-card-data"
                       >
@@ -844,6 +862,7 @@ exports[`Release Dialog Renders the environment locks two envs release 1`] = `
                           </span>
                           the other commit message 2
                         </span>
+                        )
                       </div>
                       <div
                         class="env-card-data"
@@ -998,6 +1017,7 @@ exports[`Release Dialog Renders the environment locks two envs release 1`] = `
                           </span>
                           the other commit message 3
                         </span>
+                        )
                       </div>
                       <div
                         class="env-card-data env-card-data-queue"