Removed more dev changes

freiheit-com · Nov 13, 2024 · 0597bf4 · 0597bf4
1 parent 9884266
commit 0597bf4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/services/rollout-service/pkg/argo/argo.go b/services/rollout-service/pkg/argo/argo.go
@@ -278,7 +278,6 @@ func (a *ArgoAppProcessor) DeleteArgoApps(ctx context.Context, argoApps map[stri
 		deleteAppSpan.SetTag("application", toDelete[i].Name)
 		deleteAppSpan.SetTag("namespace", toDelete[i].Namespace)
 		deleteAppSpan.SetTag("operation", "delete")
-
 		_, err := a.ApplicationClient.Delete(ctx, &application.ApplicationDeleteRequest{
 			Cascade:              nil,
 			PropagationPolicy:    nil,
@@ -293,6 +292,7 @@ func (a *ArgoAppProcessor) DeleteArgoApps(ctx context.Context, argoApps map[stri
 		if err != nil {
 			logger.FromContext(ctx).Error("deleting application: "+toDelete[i].Name, zap.Error(err))
 		}
+		deleteAppSpan.Finish()
 	}
 }
 

diff --git a/services/rollout-service/pkg/argo/argo_test.go b/services/rollout-service/pkg/argo/argo_test.go
@@ -987,6 +987,13 @@ func (a *mockArgoProcessor) DeleteArgoApps(ctx context.Context, argoApps map[str
 		}
 		toDelete = append(toDelete, argoApp)
 	}
+
+	for i := range toDelete {
+		a.ApplicationClient.Delete(ctx, &application.ApplicationDeleteRequest{
+			Name: conversion.FromString(toDelete[i].Name),
+		})
+
+	}
 }
 
 func (a *mockArgoProcessor) GetManageArgoAppsFilter() []string {