Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ffbs-parker-respondd #140

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SmithChart
Copy link
Contributor

@SmithChart SmithChart commented Nov 6, 2024

This adds ffbs-parker-nodeconfig-respondd - a package of the parker-flavor of Gluon.

This package extends respondd's statistics object with some information useful in parker networks.

Previously this package has been managed in
https://gitli.stratum0.org/ffbs/ffbs-packages under the name gluon-ffbsnext-nodeconfig-respondd.
Last commit-id: 40b02317cf00f5c7ebee15d0bef084a8e51bfa47

TODO:

@SmithChart SmithChart requested a review from grische November 6, 2024 20:52
Copy link
Contributor

@grische grische left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some formal comments. I am probably the wrong person to review this C code 🙂

ffbs-parker-nodeconfig-respondd/Makefile Outdated Show resolved Hide resolved

define Package/ffbs-parker-nodeconfig-respondd
TITLE:=respondd module for nexthop and gateway info on parker gateway nodes
DEPENDS:=+ffbs-parker-nodeconfig +respondd +kmod-nlmon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As #142 is still WIP, is this name fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the dependency name for now. But I leave this conversation open until #142 is merged.

@blocktrron
Copy link
Member

Please see #139 (comment)

@SmithChart SmithChart force-pushed the gluon-parker-nodeconfig-respondd branch from 1153a3d to ed0a062 Compare November 20, 2024 19:55
@SmithChart SmithChart changed the title Add gluon-parker-nodeconfig-respondd Add ffbs-parker-nodeconfig-respondd Nov 20, 2024
This adds ffbs-parker-nodeconfig-respondd - a package of the
*parker*-flavor of Gluon.

Previously this package has been managed in
https://gitli.stratum0.org/ffbs/ffbs-packages under the name
`gluon-ffbsnext-nodeconfig-respondd`.
Last commit-id: 40b02317cf00f5c7ebee15d0bef084a8e51bfa47
@SmithChart SmithChart force-pushed the gluon-parker-nodeconfig-respondd branch from ed0a062 to 67e1468 Compare November 20, 2024 20:02
@SmithChart SmithChart marked this pull request as draft December 15, 2024 11:45
Technically this package does not depend on ffbs-mesh-vpn-parker, so we
are safe to drop this dependency.
The `ffbs-parker-nodeconfig` package has been renamed to
`ffbs-mesh-vpn-parker`, so there is no use in keeping `nodeconfig` as
part of the name.
@maurerle maurerle changed the title Add ffbs-parker-nodeconfig-respondd Add ffbs-parker-respondd Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants