Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

autinerd
Copy link

@autinerd autinerd commented Dec 8, 2024

This adds a dark mode for the firmware selector.

@herbetom
Copy link
Member

herbetom commented Dec 8, 2024

I like the idea of a dark mode.

Hoewer, i don't think this PR can be merged this easily.

It appears to contain a device-pictures submodule? Probably some leftover from a custom fork which probably supports SVGs or PNGs (i. e. pictures without a background)?

With our current use of JPGs this won't look good. :/

Therefore i think making this work would need more significant changes.

@autinerd
Copy link
Author

autinerd commented Dec 8, 2024

Oh, sorry, I forgot to remove it.

Yes, with the JPEGs (thanks to having no transparency) it looks not so good :/ That's why I switched for our fork at https://firmware.freifunk-stuttgart.de/ to the SVGs from https://github.com/freifunk/device-pictures.

@maurerle
Copy link
Contributor

maurerle commented Dec 8, 2024

Also the router.png in this repository needs to be replaced to support transparent background:

image

@maurerle
Copy link
Contributor

maurerle commented Dec 8, 2024

This also depends on #155 for this.
And on #169
and freifunk/device-pictures#35

@maurerle
Copy link
Contributor

maurerle commented Dec 9, 2024

@autinerd could you update this PR with the css from ffs - which already has the fix for the footer - please? :)

When selecting "Upgrade" vs "Erstinstallation" the unselected part glows more, which looks as if its is selected, maybe this can be improved as well :)

@autinerd autinerd force-pushed the add-dark-mode branch 2 times, most recently from b87a8c5 to 10e9e44 Compare December 9, 2024 14:22
@autinerd
Copy link
Author

autinerd commented Dec 9, 2024

I have adjusted the shadow colors as well and added the forgotten color change for the footer :D

@herbetom herbetom self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants