Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(head): don't append page title #170

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix(head): don't append page title #170

merged 1 commit into from
Sep 23, 2024

Conversation

noxilixon
Copy link
Contributor

Resolves #169

Copy link

This is a link to a preview of the website from this Pull Request: https://freifunk.dev/page-title/.

@noxilixon noxilixon requested a review from Noki September 17, 2024 11:36
Copy link
Contributor

@FFHener FFHener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@FFHener FFHener merged commit 65de40e into main Sep 23, 2024
5 checks passed
@FFHener FFHener deleted the page-title branch September 23, 2024 10:18
@Noki
Copy link
Member

Noki commented Sep 23, 2024

@FFHener well, as mentioned there is an additional space in the title that should be removed... <title>Freifunk Berlin </title> - now that you merged it please create a PR that fixes it... ;-)

@FFHener
Copy link
Contributor

FFHener commented Sep 23, 2024

@FFHener well, as mentioned there is an additional space in the title that should be removed... <title>Freifunk Berlin </title> - now that you merged it please create a PR that fixes it... ;-)

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not append website title to page title
3 participants