Avoid unexpected "482 Request Merged" #211
Open
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2023 08:04
In certain cases 'leg_method' might be null so the IF statement:
if (leg_method && method_name && !su_casematch(method_name, leg_method))
continue;
is not working at all despite 'method_name' is not null. It leads to
leg matching process returns false positive at:
if (loose_match == NULL)
loose_match = leg;
…2.2; 17.2.3/ Implements missing matching rules (17.2.3.1 and 17.2.3.2)
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Apr 25, 2023
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Apr 25, 2023
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request consists of two commits and is aimed to avoid unexpected (wrong) "482 Request Merged" responses. These commits are implementing missing matching rules described in RFC3261 sections 17.2.3.1/2, and also fixing leg matching condition.
Use case: Call group calling process hunts sequentially for a group member that answers a group call. During a process it sends next INVITE upon previous one got canceled due to "No answer" or "Busy here" response. Such a next INVITE has different branch parameter in the topmost Via, however FreeSwitch (mod_sofia) still qualifies this new transaction as to be merged with an existing one. So the affords to add simple implementation of 17.2.3.1/2 rules and correcting the leg matching condition fixed the case.