Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/reply with all via headers in sip responses #157

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

matteolc
Copy link

@matteolc matteolc commented Jul 11, 2022

Some softswitches rely on Via header information in the 100 Trying response to be able to route calls internally (Sippy Softswitch for example). Without this information, softswitches sending calls to FreeSWITCH will fail to process the call because they are not able to match/route (internally) the INVITE with the 100 response received.
This behaviour may or may not be desirable and may or may not be SIP protocol complaint (it's internal spaghetti logic that could be avoided). However the end result is less interoperability in the wild.

The intent of this PR is to increase the interoperability of Sofia SIP/FreeSWITCH with a wider range of softswitches.

@freeswitch-ci-system
Copy link

@lazedo
Copy link
Contributor

lazedo commented Jul 11, 2022

duplicate of #41 ?

@matteolc
Copy link
Author

duplicate of #41 ?

Yes. Should I add a comment on #41 and close this PR? I wanted to raise some attention on this subject again (seemed like a stale PR)

@lazedo
Copy link
Contributor

lazedo commented Jul 11, 2022

leave it open. maybe @andywolk or @mjerris can find time to look at this (or #41)

@xadhoom
Copy link

xadhoom commented Jul 11, 2022

may I suggest to cleanup the patch from whitespaces fixes? makes hard spotting the real change ;)

@lazedo
Copy link
Contributor

lazedo commented Jul 11, 2022

@xadhoom check #41 , same without whitespace cleanup

@matteolc
Copy link
Author

Sure, no problem I will remove the linter auto corrections.

@freeswitch-ci-system
Copy link

@killdashnine
Copy link

Any update on this? Happy to make a new PR for this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants