Allow sending sip INFO messages after 183 Session Progress is received #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we receive a 183 Session Progress (Remote require us to send early media) the To header can contain a not NULL tag: SIP/2.0 183 Session progress Via: SIP/2.0/UDP 192.168.77.15;rport;branch=z9hG4bKNyU9Kg28QD3eK From: <sip:[email protected]:5060>;tag=jvl5hu58Y To: <sip:[email protected]:5060>;tag=hjmfxOj Call-ID: 7979747314492623079 ... So for the remote user agent the dialog id will become the sum of Call-ID + From-Tag + To-Tag. At this stage, if we want to send an INFO message to the other end we need to provide all three IDs like in follows: INFO sip:[email protected]:5060;transport=udp SIP/2.0 Via: SIP/2.0/UDP 192.168.77.14;rport;branch=z9hG4bKp7m2NBKcNpS1e From: <sip:[email protected]:5060>;tag=jvl5hu58Y To: <sip:[email protected]:5060>;tag=hjmfxOj Call-ID: 7979747314492623079 ... Before this patch the iNFO message was sent with the To header without any tag. The same as in original INVITE message sent to the other end Signed-off-by: Alberto Panizzo <[email protected]>
|
Scan-build found bugs: https://public-artifacts.signalwire.cloud/drone/freeswitch/sofia-sip/249/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we receive a 183 Session Progress (Remote require us to
send early media) the To header can contain a not empty tag:
SIP/2.0 183 Session progress
Via: SIP/2.0/UDP 192.168.77.15;rport;branch=z9hG4bKNyU9Kg28QD3eK
From: sip:[email protected]:5060;tag=jvl5hu58Y
To: sip:[email protected]:5060;tag=hjmfxOj
Call-ID: 7979747314492623079
...
So for the remote user agent the dialog id will become
the sum of Call-ID + From-Tag + To-Tag.
At this stage, if we want to send an INFO message to the other
end we need to provide all three IDs like in follows:
INFO sip:[email protected]:5060;transport=udp SIP/2.0
Via: SIP/2.0/UDP 192.168.77.14;rport;branch=z9hG4bKp7m2NBKcNpS1e
From: sip:[email protected]:5060;tag=jvl5hu58Y
To: sip:[email protected]:5060;tag=hjmfxOj
Call-ID: 7979747314492623079
...
Before this patch the INFO message was sent with the To header without
any tag. The same as in original INVITE message sent to the other end