Skip to content

Commit

Permalink
Fix SOA unit test issue i>different ip address and ii>mismatch codec …
Browse files Browse the repository at this point in the history
…number in sdp with changing test data.
  • Loading branch information
dhruvecosmob authored and andywolk committed Mar 29, 2022
1 parent ae1725d commit dd68c44
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions libsofia-sip-ua/soa/test_soa.c
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,8 @@ int test_codec_selection(struct context *ctx)
TEST_1(m = b_sdp->sdp_media); TEST_1(!m->m_rejected);
TEST_1(rm = m->m_rtpmaps); TEST(rm->rm_pt, 3);
TEST_S(rm->rm_encoding, "GSM");
/* Not use same payload as remote so 97 from answer */
/* We do not expect payload type as 96 here anymore as we stopped using the same payload type as remote had
since 4703f3ade78a89cdc37f673b5bde3435ab71dc27 so 97 stays. */
TEST_1(rm = rm->rm_next); TEST(rm->rm_pt, 97);
TEST_S(rm->rm_encoding, "G729");
TEST_1(rm = rm->rm_next); TEST(rm->rm_pt, 111);
Expand Down Expand Up @@ -1007,10 +1008,10 @@ int test_codec_selection(struct context *ctx)
TEST_S(rm->rm_encoding, "CN");
TEST_1(!rm->rm_next);

/* Answering end matches payload types
then sorts by local preference,
not use same payload type as remote,
then select best codec => GSM with pt 3 */
/* Answering end matches payload types then sorts by local preference,
then select best codec => GSM with pt 3
Note : we stopped using the same payload type as remote had
since 4703f3ade78a89cdc37f673b5bde3435ab71dc27 so not expect 97 here. */
TEST_1(m = b_sdp->sdp_media); TEST_1(!m->m_rejected);
TEST_1(rm = m->m_rtpmaps); TEST(rm->rm_pt, 3);
TEST_S(rm->rm_encoding, "GSM");
Expand Down Expand Up @@ -1264,7 +1265,8 @@ int test_codec_selection(struct context *ctx)
TEST_1(!m->m_next);

TEST_1(m = b_sdp->sdp_media); TEST_1(!m->m_rejected);
/* Not use same payload as remote so 97 from answer */
/* We do not expect payload type as 96 here anymore as we stopped using the same payload type as remote had
since 4703f3ade78a89cdc37f673b5bde3435ab71dc27 so 97 stays. */
TEST_1(rm = m->m_rtpmaps); TEST(rm->rm_pt, 97);
TEST_S(rm->rm_encoding, "G729");
TEST_1(rm = rm->rm_next); TEST(rm->rm_pt, 111);
Expand Down Expand Up @@ -2242,11 +2244,11 @@ int test_address_selection(struct context *ctx)
TEST_OC_ADDRESS(a, "2001:1508:1003::21a:a0ff:fe71:813", ip6);
TEST_VOID(soa_terminate(a, NULL));

/* SOATAG_AF(SOA_AF_IP4_IP6) and SOATAG_USER_O_LINE() tag remove so, o= mentions IP6 => select IP4 */
n = soa_set_user_sdp(a, 0, "o=- 1 1 IN IP4 ::\r\n"
/* SOATAG_AF(SOA_AF_IP4_IP6) and SOATAG_USER_O_LINE() tag remove from so, o= mentions IP6 => select IP6 */
n = soa_set_user_sdp(a, 0, "o=- 1 1 IN IP6 ::\r\n"
"m=audio 5008 RTP/AVP 0 8", -1); TEST(n, 1);
n = soa_generate_offer(a, 1, test_completed); TEST(n, 0);
TEST_OC_ADDRESS(a, "11.12.13.14", ip4);
TEST_OC_ADDRESS(a, "2001:1508:1003::21a:a0ff:fe71:813", ip6);
TEST_VOID(soa_process_reject(a, NULL));

/* SOATAG_AF(SOA_AF_IP4_IP6), c= uses non-local IP6
Expand Down

0 comments on commit dd68c44

Please sign in to comment.