Preserve local sdp's order of media lines in soa_sdp_expand_media(). …

…Add sdp_media_exists() API.
freeswitch · Apr 30, 2024 · 1d49bca · 1d49bca
1 parent 0a50b84
commit 1d49bca
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 11 deletions.
diff --git a/libsofia-sip-ua/sdp/sdp.c b/libsofia-sip-ua/sdp/sdp.c
@@ -1845,6 +1845,20 @@ unsigned sdp_media_count_with(sdp_session_t const *sdp,
   return count;
 }
 
+/** Find matching media line in SDP. */
+sdp_media_t** sdp_media_exists(sdp_session_t const *sdp,
+                              sdp_media_t const *m0)
+{
+    sdp_media_t **m;
+
+    if (sdp != NULL)
+        for (m = &sdp->sdp_media; *m; m = &(*m)->m_next)
+            if (sdp_media_match_with(*m, m0))
+                return m;
+
+    return NULL;
+}
+
 /** Return true if media uses RTP */
 int sdp_media_uses_rtp(sdp_media_t const *m)
 {

diff --git a/libsofia-sip-ua/sdp/sofia-sip/sdp.h b/libsofia-sip-ua/sdp/sofia-sip/sdp.h
@@ -496,6 +496,9 @@ SOFIAPUBFUN unsigned sdp_media_count(sdp_session_t const *sdp,
 SOFIAPUBFUN unsigned sdp_media_count_with(sdp_session_t const *sdp,
 					  sdp_media_t const *m0);
 
+SOFIAPUBFUN sdp_media_t** sdp_media_exists(sdp_session_t const *sdp,
+						   sdp_media_t const *m0);
+
 /** Return true if media uses RTP */
 SOFIAPUBFUN int sdp_media_uses_rtp(sdp_media_t const *m);
 

diff --git a/libsofia-sip-ua/soa/soa_static.c b/libsofia-sip-ua/soa/soa_static.c
@@ -301,23 +301,42 @@ sdp_session_t *soa_sdp_expand_media(su_home_t *home,
 				    sdp_session_t const *truncated,
 				    sdp_session_t const *complete)
 {
+  sdp_session_t *tmp_truncated;
   sdp_session_t *expanded;
-  sdp_media_t **m0;
-  sdp_media_t * const *m1;
+  sdp_media_t **mE;
+  sdp_media_t **mT;
+  sdp_media_t * const *mC;
 
+  /* Truncated list that we will be reducing */
+  tmp_truncated = sdp_session_dup(home, truncated);
+  /* New resulting list */
   expanded = sdp_session_dup(home, truncated);
 
   if (expanded) {
-    for (m0 = &expanded->sdp_media, m1 = &complete->sdp_media;
-	 *m1;
-	 m1 = &(*m1)->m_next) {
-      if (!*m0) {
-	*m0 = soa_sdp_make_rejected_media(home, *m1, expanded, 0);
-	if (!*m0)
-	  return NULL;
+      expanded->sdp_media = NULL; /* Empty the list of medias */
+      mE = &expanded->sdp_media;  /* Pointer to the beginning of the new list */
+
+      /* Loop through all items in the complete list to preserve complete list's order */
+      for (mC = &complete->sdp_media; *mC; mC = &(*mC)->m_next) {
+          /* Find the corresponding media in the truncated list */
+          if ((mT = sdp_media_exists(tmp_truncated, *mC))) {
+              /* Copy the corresponding media from the truncated list to the new list */
+              *mE = sdp_media_dup(home, *mT, expanded);
+              if (!*mE)
+                return NULL;
+
+              /* Remove corresponding media from the truncated list */
+              mT = &(*mT)->m_next;
+          } else {
+              /* If the corresponding media was not found in the truncated list, add a rejected media */
+              *mE = soa_sdp_make_rejected_media(home, *mC, expanded, 0);
+              if (!*mE)
+                return NULL;
+          }
+
+          /* Prepare pointer of the new list for a new item */
+          mE = &(*mE)->m_next;
       }
-      m0 = &(*m0)->m_next;
-    }
   }
 
   return expanded;