perf: Optimize performance by preventing memory leaks and reducing un…

…necessary operations
freenet · Nov 27, 2024 · c41802f · c41802f
1 parent b2ebbbe
commit c41802f
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 13 deletions.
diff --git a/hugo-site/static/js/small-world-comparison.js b/hugo-site/static/js/small-world-comparison.js
@@ -218,9 +218,26 @@ waitForD3().then(() => {
         });
     }
 
+    // Keep SVG reference
+    let statsSvg;
+
     function updateStats() {
         const statsDiv = document.getElementById('statsGraph');
 
+        // Reset stats after certain threshold to prevent overflow
+        if (smallWorldNetwork.stats.attempts > 1000) {
+            smallWorldNetwork.stats = { 
+                success: 0, 
+                attempts: 0, 
+                totalPathLength: 0 
+            };
+            randomNetwork.stats = { 
+                success: 0, 
+                attempts: 0, 
+                totalPathLength: 0 
+            };
+        }
+
         const swSuccess = smallWorldNetwork.stats.attempts === 0 ? 0 :
             (smallWorldNetwork.stats.success / smallWorldNetwork.stats.attempts * 100);
         const swAvgPath = smallWorldNetwork.stats.success === 0 ? 0 :
@@ -231,8 +248,15 @@ waitForD3().then(() => {
         const rnAvgPath = randomNetwork.stats.success === 0 ? 0 :
             (randomNetwork.stats.totalPathLength / randomNetwork.stats.success);
 
-        // Clear previous graph
-        statsDiv.innerHTML = '';
+        // Create or reuse SVG
+        if (!statsSvg) {
+            statsDiv.innerHTML = '';
+            statsSvg = d3.select('#statsGraph')
+                .append('svg')
+                .attr('width', width + margin.left + margin.right)
+                .attr('height', height + margin.top + margin.bottom);
+        }
+        statsSvg.selectAll('*').remove();
 
         // Create SVG
         const margin = {top: 30, right: 60, bottom: 40, left: 60};

diff --git a/hugo-site/static/js/small-world-routing.js b/hugo-site/static/js/small-world-routing.js
@@ -231,12 +231,12 @@ async function initVisualization() {
     }
 
     function animatePath() {
-        if (!isPlaying) return;
-
-        // Cancel any existing animation
-        if (animationFrame) {
-            cancelAnimationFrame(animationFrame);
-            animationFrame = null;
+        if (!isPlaying) {
+            if (animationFrame) {
+                cancelAnimationFrame(animationFrame);
+                animationFrame = null;
+            }
+            return;
         }
 
         const path = findPath(sourceNode, targetNode);

diff --git a/hugo-site/static/js/small-world-scale.js b/hugo-site/static/js/small-world-scale.js
@@ -211,20 +211,22 @@ waitForD3().then(() => {
         return null;
     }
 
+    // Keep SVG reference to avoid repeated selections
+    let chartSvg;
+
     function updateChart() {
         const margin = {top: 20, right: 20, bottom: 60, left: 50};
         const chartWidth = width - margin.left - margin.right;
         const chartHeight = height - margin.top - margin.bottom;
 
-        // Create SVG if it doesn't exist
-        let svg = d3.select('#scalingChart svg');
-        if (svg.empty()) {
-            svg = d3.select('#scalingChart')
+        // Create or reuse SVG
+        if (!chartSvg) {
+            chartSvg = d3.select('#scalingChart')
                 .append('svg')
                 .attr('width', width)
                 .attr('height', height);
         }
-        svg.selectAll('*').remove();
+        chartSvg.selectAll('*').remove();
 
         const g = svg.append('g')
             .attr('transform', `translate(${margin.left},${margin.top})`);
@@ -332,6 +334,12 @@ waitForD3().then(() => {
                                    numPeers < 200 ? 20 :
                                    numPeers < 350 ? 25 : 30;
                     numPeers += stepSize;
+
+                    // Limit array size to prevent memory growth
+                    if (averagePathLengths.length > 100) {
+                        const keepEvery = Math.ceil(averagePathLengths.length / 100);
+                        averagePathLengths = averagePathLengths.filter((_, i) => i % keepEvery === 0);
+                    }
 
                     // Allow UI updates between iterations
                     if (i < batchSize - 1) {