Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

184207213 - Improve observability tools #892

Merged
merged 8 commits into from
Nov 13, 2023

Conversation

iduartgomez
Copy link
Collaborator

@iduartgomez iduartgomez commented Nov 10, 2023

This PR makes the changes so we have an opt-in feature for collecting trace and log data in the open telemetry standard through a jaeger exporter. Jagger accepts multiple backend databases (e.g. elastic, prometheus) so we can build on top of the platform for flexibly exploring telemetry data. Also building on top of OT will allows to add metrics in the future if we need to and add opt-in remote telemetry, as well as enable this in simulations, test-network and collect remotely in a seamless way.

We collect logs per spans per node, in network mode each peer will be like a single service, and in local mode (for simple in-memory tests) each simulated node has it's own root span so is easy to check info.

There is, additionally, spans created per operation type, where the life of a transaction can be followed and all logs properly classified per transaction, this is done through a custom event register which creates OT traces and logs leveraging our own event registry system, and is independent of the per-node traces.

This is not enabled by default, since it requires a working jaeger collector.

TODO: add some documentation on how to use this.

@iduartgomez iduartgomez force-pushed the 184207213-more-observability-tools branch from 53cf472 to b01759a Compare November 13, 2023 09:15
@iduartgomez iduartgomez marked this pull request as ready for review November 13, 2023 09:22
@iduartgomez iduartgomez force-pushed the 184207213-more-observability-tools branch from a4851df to 0b3cf8e Compare November 13, 2023 09:37
@iduartgomez iduartgomez force-pushed the 184207213-more-observability-tools branch from c6c9f8e to c28659e Compare November 13, 2023 10:08
@iduartgomez iduartgomez merged commit 3c51d0d into main Nov 13, 2023
2 of 3 checks passed
@iduartgomez iduartgomez deleted the 184207213-more-observability-tools branch November 13, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant