186394182 - minor store fixes #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iduartgomez
force-pushed
the
186394182-minor-store-fixes
branch
from
9ae28dc to
ee1b5e1
Compare
iduartgomez
force-pushed
the
186394182-minor-store-fixes
branch
from
ee1b5e1 to
92ec60b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes ensure that multiple core processes running concurrently (e.g. embedded kernel in an app and a background daemon running at the same time) won't corrupt the index files for contract/delegate stores etc. Indexes are now append only and compacted (clean up) periodically via kernel file locks.
This should make this efficient and data race free.