Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

186293095 - Add more connections dinamically #888

Merged
merged 22 commits into from
Nov 7, 2023
Merged

186293095 - Add more connections dinamically #888

merged 22 commits into from
Nov 7, 2023

Conversation

iduartgomez
Copy link
Collaborator

@iduartgomez iduartgomez commented Nov 6, 2023 •
edited
Loading

Changes in this PR:

  • Peers will try to acquire more connections automatically now if they don't have reached the max number of connections.
    Now we have a background task that will maintain the quality and number of connections automatically.
  • Ideal join location criteria selected by topology manager now.
  • Operations now time out and are clean up automatically.
  • Fixed multiple minor issues with the connect op so all state transitions are correct now.
  • Fixed some issues with the event log serialization, more robust testing.
  • Optimized transaction type so is more packed and faster to copy (only 16 bytes size now)

@iduartgomez
Fix issues with event log serialization
54b1d2e 
and log truncation
@iduartgomez
Fix error in truncate test
24dae21
@iduartgomez
Make Transaction type more packed
426faf7
@iduartgomez
Add functionality to ring type to acquire new connections
a30630e
@iduartgomez
Clean up connection forwarding
318ad48
@iduartgomez
Add new conn acquisition routine to connect op
f2bfc97
@iduartgomez
Cleanup connections w/o alive transactions
caedd56
@iduartgomez
Remove deadlockick from conn_maintenace
e346a16
@iduartgomez
Remove timed out transactions
f4e950e
@iduartgomez
Add new connections while possible
82fe032
@iduartgomez
Don't target the joiner when requesting more connections
b24a2f2
@iduartgomez
Should also avoid forwarding to joiner in regular gw joins
b1bb8ea
@iduartgomez
Fix last issues with additional connections
10ebfe7
@iduartgomez
tm: change old module naming way to new one
d54f6db
@iduartgomez
tm: Remove needless Rc
6a826fd
@iduartgomez
Use topology manager to decide target locations
e28c6df
@iduartgomez iduartgomez force-pushed the 186293095-add-more-connections-dinamically branch from 8bc5080 to e3aa791 Compare November 6, 2023 15:25
@iduartgomez iduartgomez force-pushed the 186293095-add-more-connections-dinamically branch from e3aa791 to 007ceab Compare November 6, 2023 15:27
@iduartgomez iduartgomez requested a review from sanity November 6, 2023 15:33
@iduartgomez iduartgomez force-pushed the 186293095-add-more-connections-dinamically branch from 2701b5e to 49a281f Compare November 6, 2023 16:30
sanity
sanity reviewed Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@sanity sanity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions

crates/core/src/ring.rs Show resolved Hide resolved
crates/core/src/ring.rs Show resolved Hide resolved
crates/core/src/ring.rs Outdated Show resolved Hide resolved
crates/core/src/ring.rs Outdated Show resolved Hide resolved
@iduartgomez iduartgomez force-pushed the 186293095-add-more-connections-dinamically branch from 5c555fe to 959b855 Compare November 7, 2023 08:41
@iduartgomez iduartgomez force-pushed the 186293095-add-more-connections-dinamically branch from c9e70fc to 01f310c Compare November 7, 2023 10:48
@iduartgomez iduartgomez force-pushed the 186293095-add-more-connections-dinamically branch from 08a6485 to 2aed99a Compare November 7, 2023 12:19
@iduartgomez iduartgomez merged commit 48f6a12 into main Nov 7, 2023
@iduartgomez iduartgomez deleted the 186293095-add-more-connections-dinamically branch November 7, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanity sanity sanity left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iduartgomez @sanity