remove_validate_delta #1263
Closed
remove_validate_delta #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
compiles in my computer if combined with the stdlib PR. current tests already broken by older PRs. no more tests added. |
|
You must probably update the stdlib submodule commit to see that it works, there is a new failing test otherwise |
|
Update the submodule to last stdlib |
gogo2464
force-pushed
the
remove-validate-delta
branch
from
75f2cec to
b039b6b
Compare
|
I just need to push again |
Merged
|
Completed in #1274 |
|
painful to see such duplicated. I hope he forked me. |
|
Your PR was broken and as a result we had a broken incompatible version which was not in sync with stdlib. I had to finish this up sorry, next time complete the changes in one go. |
|
nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:
#1243