Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid check gateways file in local simulation #1234

Merged
merged 1 commit into from
Sep 22, 2024
+3 −1
Merged

Avoid check gateways file in local simulation #1234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/core/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,8 @@ impl ConfigArgs {
.gateways
}
Err(err) => {
#[cfg(not(any(test, debug_assertions)))]
// FIXME: Remove local-simulation feature and use runtime flags
#[cfg(all(not(any(test, debug_assertions)), not(feature = "local-simulation")))]
{
if peer_id.is_none() && mode == OperationMode::Network {
tracing::error!(file = ?gateways_file, "Failed to read gateways file: {err}");
Expand Down
1 change: 1 addition & 0 deletions crates/core/src/node/testing_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ impl SimNetwork {

let mut config_args = ConfigArgs::default();
config_args.id = Some(format!("{label}"));
// FIXME: Is necessary use config_args.build() for the simulation. Related with the FXIME in Config line 238
let mut config = NodeConfig::new(config_args.build().unwrap()).await.unwrap();
config.key_pair = keypair;
config.network_listener_ip = Ipv6Addr::LOCALHOST.into();
Expand Down
Loading