Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix event_log truncate #1109

Merged
merged 16 commits into from
Jun 6, 2024
Merged

fix event_log truncate #1109

merged 16 commits into from
Jun 6, 2024

Conversation

al8n
Copy link
Collaborator

@al8n al8n commented Jun 3, 2024 •
edited
Loading

No description provided.

@al8n al8n changed the title WIP: fix event_log_test fix event_log truncate Jun 5, 2024
iduartgomez
iduartgomez reviewed Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@iduartgomez iduartgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is fixed, do we need the state additional bookkeeping or can we clean that up? Was only for debugging afaik.

@al8n
Copy link
Collaborator Author

al8n commented Jun 5, 2024

If this is fixed, do we need the state additional bookkeeping or can we clean that up? Was only for debugging afaik.

Do we want to integrate the event log states to some metrics like prometheus or not? If not, I can remove them.

@iduartgomez
Copy link
Collaborator

If this is fixed, do we need the state additional bookkeeping or can we clean that up? Was only for debugging afaik.

Do we want to integrate the event log states to some metrics like prometheus or not? If not, I can remove them.

Not for now, and if we do that, we will do it at the tracing collector level anyways (where we have the jaeger collector etc). So let's clean this up (or gate it behind the test/debug_assertions feature at least

@al8n al8n requested a review from iduartgomez June 6, 2024 05:59
@al8n al8n merged commit 82738a2 into main Jun 6, 2024
2 of 5 checks passed
@al8n al8n deleted the aof branch June 6, 2024 08:04
iduartgomez pushed a commit that referenced this pull request Sep 20, 2024
@al8n @iduartgomez
fix event_log truncate (#1109)
ba49c19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iduartgomez iduartgomez iduartgomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@al8n @iduartgomez