Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle attachment number rows with six child elements #406

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

ttys0dev
Copy link
Contributor

Looks like some of these(like ca1) have six elements.

@ERosendo ERosendo self-requested a review November 16, 2024 19:12
@ERosendo ERosendo self-assigned this Nov 16, 2024
Copy link
Contributor

@ERosendo ERosendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ttys0dev, the code looks good!

For future reference, here's an example from ca1 illustrating the attachment table structure:

image

The attachment table includes a checkbox, attachment number, document link, description, page count, and file size (the 6th element).

@mlissner
Copy link
Member

Looks like we just need some release notes and we can merge.

@ERosendo
Copy link
Contributor

@mlissner I'll handle it.

@ERosendo ERosendo merged commit ab7ff58 into freelawproject:main Nov 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants