Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest.json: More COA ACMS websites #345

Merged

Conversation

johnhawkinson
Copy link
Collaborator

ACMS docket report webpages return Javascript that sets the _models attribute of the window global object to structued data, which include a reference to API urls, e.g.:

window._model.AppSettings.ApiUrl
"https://ca9-showdocservices.azurewebsites.us/api"

Consequently, include the ca*-showdocservices websites in our permission list, again out of an abundance of caution.

@johnhawkinson johnhawkinson added the no changelog Override Check Changelog Action. label Sep 27, 2023
ACMS docket report webpages return Javascript that sets the `_models`
attribute of the `window` global object to structured data, which
include a reference to API urls, e.g.:

  >> window._model.AppSettings.ApiUrl
  "https://ca9-showdocservices.azurewebsites.us/api"

Consequently, include the ca*-showdocservices websites in our
permission list, again out of an abundance of caution.
@mlissner mlissner merged commit 6a7b497 into freelawproject:main Sep 27, 2023
4 checks passed
@mlissner
Copy link
Member

Thanks. We're doing the right thing here by being explicit, but I worry that a really long list of domains is scarier to many users than a wildcard. Would it work to do something like ca*.azurewebsites.us? I dunno. It might be less scary to people.

@johnhawkinson
Copy link
Collaborator Author

johnhawkinson commented Sep 27, 2023

In fact it would not work.
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns#host


The host component may take one of three forms:

Form Matches
* Any host.
*. followed by part of the hostname. The given host and any of its subdomains.
A complete hostname, without wildcards. Only the given host.

host must not include a port number.

host is optional only if the scheme is "file".

Note that the wildcard may only appear at the start.


emphasis mine

@mlissner
Copy link
Member

Well that settles that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Override Check Changelog Action.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants