Fix court string matching with whitespace #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlissner
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
LGTM.
My understanding is that in this comment #135 (comment), @flooie eliminated duplicate abbreviations from courts DB, so now it's safe to do things like this.
@flooie, wil you give this a quick review too? The only changes you need to look at are in resolve.py, the rest is updating Black.
Assuming this is good, we need to return to:
- Court name issues #129 (might be obsolete)
- Court name errors #128 (might be fixed)
- Getting full citation span #135 (don't we already support this, regardless of the code here?)
|
@flooie looks like this one never got your approval. Mind taking a look, please? |
|
Want me to rebase this? |
|
That'd be great, thanks @mattdahl |
mattdahl
force-pushed
the
issue-135-fix-court-string-matching
branch
from
94b1e2f
to
96dcc84
Compare
mattdahl
force-pushed
the
issue-135-fix-court-string-matching
branch
2 times, most recently
from
2d0f7cb
to
c9b4d78
Compare
|
Thanks. I'll take a look soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #135 (comment), there is presently a bug where court strings without whitespace are not properly matched. 3b2fe09 implements a failing test for this bug. 94b1e2f implements a simple fix.
This PR is also related to the changes proposed in #129, but I think that that proposal has been made obsolete with the removal of all the duplicate citation strings by @flooie (#135 (comment)). In any case, this PR addresses a different problem re whitespace.
Note that this PR is based off of #143 (needed to update black to make GitHub Actions happy), so that should be merged first.